Skip to content

Commit

Permalink
Added small improvements for the compatibility check
Browse files Browse the repository at this point in the history
Pipelined stderr from npm run generate to skip redundant tmp file.
Removed -q parameter from grep, as we'd like to see errors in pipeline to troubleshoot issues
  • Loading branch information
oskardudycz committed Mar 9, 2024
1 parent 1624935 commit c48a83a
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 1,015 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ jobs:
working-directory: ./e2e/esmCompatibility
shell: bash
run: |
if npm run generate 2> tmp.txt && cat tmp.txt | grep -iqF '[request error]'; then
echo "Errors found, failing the step." && exit 1
if npm run generate 2> | grep -iF '[request error]'; then
echo "Errors found, failing the step."
else
echo "No errors found, proceeding..."
fi
Loading

0 comments on commit c48a83a

Please sign in to comment.