Skip to content

Commit

Permalink
Made message_kind column to be char(1) instead of Text
Browse files Browse the repository at this point in the history
  • Loading branch information
oskardudycz committed Feb 27, 2025
1 parent 0f17e3a commit cbf759c
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,9 @@ const appendEventsRaw = (
.join(','),
messages.map(() => `'1'`).join(','),
messages.map((e) => sql('%L', e.type)).join(','),
messages.map((e) => sql('%L', e.kind)).join(','),
messages
.map((e) => sql('%L', e.kind === 'Event' ? 'E' : 'C'))
.join(','),
streamId,
streamType,
options?.expectedStreamVersion ?? 'NULL',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const messagesTableSQL = rawSql(
stream_id TEXT NOT NULL,
stream_position BIGINT NOT NULL,
partition TEXT NOT NULL DEFAULT '${globalTag}',
message_kind TEXT NOT NULL DEFAULT 'Event',
message_kind CHAR(1) NOT NULL DEFAULT 'E',
message_data JSONB NOT NULL,
message_metadata JSONB NOT NULL,
message_schema_version TEXT NOT NULL,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,6 @@ const appendEventsRaw = async (
events,
expectedStreamVersion,
streamId,
streamType,
options?.partition?.toString() ?? defaultTag,
);

Expand Down Expand Up @@ -239,7 +238,6 @@ const buildEventInsertQuery = (
events: ReadEvent[],
expectedStreamVersion: bigint,
streamId: string,
streamType: string,
partition: string | null | undefined,
): {
sqlString: string;
Expand All @@ -265,6 +263,7 @@ const buildEventInsertQuery = (
streamId,
streamPosition.toString() ?? 0,
partition ?? defaultTag,
event.kind === 'Event' ? 'E' : 'C',
JSONParser.stringify(event.data),
JSONParser.stringify(event.metadata),
expectedStreamVersion?.toString() ?? 0,
Expand All @@ -286,6 +285,7 @@ const buildEventInsertQuery = (
stream_id,
stream_position,
partition,
message_kind,
message_data,
message_metadata,
message_schema_version,
Expand Down
2 changes: 1 addition & 1 deletion src/packages/emmett-sqlite/src/eventStore/schema/tables.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const messagesTableSQL = sql(
stream_id TEXT NOT NULL,
stream_position BIGINT NOT NULL,
partition TEXT NOT NULL DEFAULT '${globalTag}',
message_kind TEXT NOT NULL DEFAULT 'Event',
message_kind CHAR(1) NOT NULL DEFAULT 'E',
message_data JSONB NOT NULL,
message_metadata JSONB NOT NULL,
message_schema_version TEXT NOT NULL,
Expand Down

0 comments on commit cbf759c

Please sign in to comment.