Updated API tests to use strongly-typed Event Store type #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was always taking the Event Store implementation which was forcing to do casting while setting up, which was not great. Fixed also Event Store wrapper to just override the needed methods passing the rest as they are. Without it, event store extensions (like MongoDB projections api) wouldn't work. Removed event store wrapper usage from E2E tests, as it was redundant: checks are only made on responses.
|
@thiagomini FYI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was always taking the Event Store implementation, which was forcing to do casting while setting up, which was not great.
Fixed also Event Store wrapper to just override the needed methods passing the rest as they are. Without it, even store extensions (like MongoDB projections API) wouldn't work.
Removed event store wrapper usage from E2E tests, as it was redundant: checks are only made on responses.