Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Traffic light module #154

Merged
merged 14 commits into from
Feb 19, 2025
Merged

Enable Traffic light module #154

merged 14 commits into from
Feb 19, 2025

Conversation

habby1012
Copy link
Collaborator

@habby1012 habby1012 commented Feb 18, 2025

Users can use a new script, which runs with traffic light module enabled.

Copy link
Owner

@evshary evshary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to add how to run traffic light in our tutorial.


# Run the program
parallel --verbose --lb ::: \
"ros2 launch autoware_carla_launch autoware_zenoh.launch.xml is_simulation:=false use_traffic_light_recognition:=true \
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot why we need is_simulation:=false. Could you please add the comment here?

Copy link
Owner

@evshary evshary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evshary evshary merged commit 03ce8a5 into main Feb 19, 2025
2 checks passed
@evshary evshary deleted the traffic_light branch February 19, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants