Next: Project Management #1856
Merged
Next: Project Management #1856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niemyjski
force-pushed
the
feature/next-project-management
branch
from
f49afbc to
b8c32b9
Compare
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds project management capabilities while refactoring and enhancing OAuth authentication and query key consistency. Key changes include:
- Updating the query key for stack count queries to include request parameters.
- Adding Slack OAuth login support and refactoring related authentication functions.
- Updating internal documentation and guidelines.
Reviewed Changes
Copilot reviewed 168 out of 184 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Exceptionless.Web/ClientApp/src/lib/features/events/api.svelte.ts | Updated query key in getStackCountQuery to incorporate additional parameters. |
| src/Exceptionless.Web/ClientApp/src/lib/features/auth/index.svelte.ts | Added Slack OAuth login support and refactored OAuth helper functions with improved error handling. |
| src/Exceptionless.Web/ClientApp/resources.md | Introduced internal notes regarding migration to Svelte's class directive and model generation. |
| .github/copilot-instructions.md | Updated code style instructions related to single-line control statements. |
Files not reviewed (16)
- .vscode/launch.json: Language not supported
- .vscode/settings.json: Language not supported
- src/Exceptionless.Web/ClientApp/.npmrc: Language not supported
- src/Exceptionless.Web/ClientApp/package.json: Language not supported
- src/Exceptionless.Web/ClientApp/src/lib/features/events/components/events-overview.svelte: Language not supported
- src/Exceptionless.Web/ClientApp/src/lib/features/events/components/extended-data-item.svelte: Language not supported
- src/Exceptionless.Web/ClientApp/src/lib/features/events/components/filters/boolean-faceted-filter-trigger.svelte: Language not supported
- src/Exceptionless.Web/ClientApp/src/lib/features/events/components/filters/date-faceted-filter-trigger.svelte: Language not supported
- src/Exceptionless.Web/ClientApp/src/lib/features/events/components/filters/level-faceted-filter-trigger.svelte: Language not supported
- src/Exceptionless.Web/ClientApp/src/lib/features/events/components/filters/number-faceted-filter-trigger.svelte: Language not supported
- src/Exceptionless.Web/ClientApp/src/lib/features/events/components/filters/project-faceted-filter-trigger.svelte: Language not supported
- src/Exceptionless.Web/ClientApp/src/lib/features/events/components/filters/project-faceted-filter.svelte: Language not supported
- src/Exceptionless.Web/ClientApp/src/lib/features/events/components/filters/reference-faceted-filter-trigger.svelte: Language not supported
- src/Exceptionless.Web/ClientApp/src/lib/features/events/components/filters/session-faceted-filter-trigger.svelte: Language not supported
- src/Exceptionless.Web/ClientApp/src/lib/features/events/components/filters/status-faceted-filter-trigger.svelte: Language not supported
- src/Exceptionless.Web/ClientApp/src/lib/features/events/components/filters/string-faceted-filter-trigger.svelte: Language not supported
| @@ -230,7 +230,7 @@ export function getStackCountQuery(request: GetStackCountRequest) { | |||
|
|
|||
| return response.data!; | |||
| }, | |||
| queryKey: queryKeys.stacksCount(request.route.stackId) | |||
| queryKey: [...queryKeys.stacksCount(request.route.stackId), { params: request.params }] | |||
There was a problem hiding this comment.
[nitpick] Consider clarifying or documenting the addition of { params: request.params } in the query key to ensure it aligns with caching best practices and does not unintentionally affect cache consistency.
Suggested change
| queryKey: [...queryKeys.stacksCount(request.route.stackId), { params: request.params }] | |
| queryKey: [...queryKeys.stacksCount(request.route.stackId), { params: JSON.stringify(request.params) }] |
Copilot uses AI. Check for mistakes.
| @@ -5,6 +5,8 @@ | |||
| ### TODO | |||
|
|
|||
| - Investigate loading data in - export function load({ url, fetch }) {} | |||
| - <https://svelte.dev/docs/svelte/class#The-class:-directive> migrate from cn / cslx | |||
There was a problem hiding this comment.
[nitpick] Consider providing more context or clarifying the note 'migrate from cn / cslx' to improve internal documentation clarity.
Suggested change
| - <https://svelte.dev/docs/svelte/class#The-class:-directive> migrate from cn / cslx | |
| - <https://svelte.dev/docs/svelte/class#The-class:-directive> Migrate from "cn" (class names) and "cslx" (class string library) to a unified approach. Consider using a modern utility like "clsx" or "classnames" for managing class names. |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ability to list, add, configure and manage projects.