Add practice exercise line-up#1620
Conversation
|
Thank you for contributing to Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:
Automated comment created by PR Commenter 🤖. |
There was a problem hiding this comment.
Pull request overview
Adds the new Elixir practice exercise “Line-up”, introducing learners to generating English ordinal suffixes and interpolating them into a fixed sentence format, and registers the exercise in the track configuration.
Changes:
- Add the new
line-upexercise skeleton (stub module, tests, Mix project files, formatter/gitignore). - Add exercise authoring metadata (
.meta/config.json, example solution, generatedtests.toml) plus learner-facing docs (.docs/*). - Register the exercise in the track-level
config.json.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| exercises/practice/line-up/test/test_helper.exs | Standard ExUnit setup for pending tests. |
| exercises/practice/line-up/test/line_up_test.exs | Adds test suite covering ordinal suffix rules. |
| exercises/practice/line-up/mix.exs | Adds Mix project definition for the exercise. |
| exercises/practice/line-up/lib/line_up.ex | Adds the student-facing stub API (LineUp.format/2). |
| exercises/practice/line-up/.meta/tests.toml | Adds configlet-generated test UUID mapping. |
| exercises/practice/line-up/.meta/example.ex | Adds reference implementation for ordinal suffix formatting. |
| exercises/practice/line-up/.meta/config.json | Adds exercise metadata (files, blurb, attribution). |
| exercises/practice/line-up/.gitignore | Adds standard Mix build/deps ignores. |
| exercises/practice/line-up/.formatter.exs | Adds formatter configuration for the exercise. |
| exercises/practice/line-up/.docs/introduction.md | Adds narrative introduction for the exercise. |
| exercises/practice/line-up/.docs/instructions.md | Adds problem statement and suffix rules. |
| config.json | Registers line-up in the Elixir track exercise list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jiegillet
left a comment
There was a problem hiding this comment.
This looks great, nice job!
I left some small comments, let me know what you think.
config.json
Outdated
| }, | ||
| { | ||
| "slug": "line-up", | ||
| "name": "Line-up", |
There was a problem hiding this comment.
I think the official name doesn't have a dash: https://github.com/exercism/problem-specifications/blob/main/exercises/line-up/metadata.toml
(BTW, this is a neat little contribution someone could make to the generator in a separate PR: read the name from that file instead of using "TODO")
There was a problem hiding this comment.
(BTW, this is a neat little contribution someone could make to the generator in a separate PR: read the name from that file instead of using "TODO")
Great idea. As soon as I have time, I'll do the PR for that too.
In the meantime, I'll create an issue so it stays marked and we can remember it. (#1621)
EDIT: precheck keeps failing, but I don't see any problems.
There was a problem hiding this comment.
The precheck was failing because the test file wasn't formatted correctly after your changes. I pushed a commit to fix it.
jiegillet
left a comment
There was a problem hiding this comment.
Looks great, thank you very much :)
https://forum.exercism.org/t/adding-exercises-to-elixir-track/33067/2