Skip to content

Add practice exercise line-up#1620

Merged
jiegillet merged 7 commits intoexercism:mainfrom
FraSanga:line-up
Mar 11, 2026
Merged

Add practice exercise line-up#1620
jiegillet merged 7 commits intoexercism:mainfrom
FraSanga:line-up

Conversation

@FraSanga
Copy link
Contributor

@FraSanga FraSanga commented Mar 8, 2026

Copilot AI review requested due to automatic review settings March 8, 2026 17:33
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2026

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?
  • Practice exercise changed

    • 🌲 Do prerequisites, practices, and difficulty in config.json need to be updated?
    • 🧑‍🏫 Are the changes in accordance with the community-wide problem specifiations?
  • Practice exercise tests changed

    • ⚪️ Are all tests except the first one skipped?
    • 📜 Does <exercise>/.meta/tests.toml need updating?

Automated comment created by PR Commenter 🤖.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the new Elixir practice exercise “Line-up”, introducing learners to generating English ordinal suffixes and interpolating them into a fixed sentence format, and registers the exercise in the track configuration.

Changes:

  • Add the new line-up exercise skeleton (stub module, tests, Mix project files, formatter/gitignore).
  • Add exercise authoring metadata (.meta/config.json, example solution, generated tests.toml) plus learner-facing docs (.docs/*).
  • Register the exercise in the track-level config.json.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
exercises/practice/line-up/test/test_helper.exs Standard ExUnit setup for pending tests.
exercises/practice/line-up/test/line_up_test.exs Adds test suite covering ordinal suffix rules.
exercises/practice/line-up/mix.exs Adds Mix project definition for the exercise.
exercises/practice/line-up/lib/line_up.ex Adds the student-facing stub API (LineUp.format/2).
exercises/practice/line-up/.meta/tests.toml Adds configlet-generated test UUID mapping.
exercises/practice/line-up/.meta/example.ex Adds reference implementation for ordinal suffix formatting.
exercises/practice/line-up/.meta/config.json Adds exercise metadata (files, blurb, attribution).
exercises/practice/line-up/.gitignore Adds standard Mix build/deps ignores.
exercises/practice/line-up/.formatter.exs Adds formatter configuration for the exercise.
exercises/practice/line-up/.docs/introduction.md Adds narrative introduction for the exercise.
exercises/practice/line-up/.docs/instructions.md Adds problem statement and suffix rules.
config.json Registers line-up in the Elixir track exercise list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

FraSanga and others added 4 commits March 8, 2026 18:44
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@FraSanga FraSanga changed the title Line-up practice exercise Add practice exercise line-up Mar 8, 2026
Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, nice job!

I left some small comments, let me know what you think.

config.json Outdated
},
{
"slug": "line-up",
"name": "Line-up",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the official name doesn't have a dash: https://github.com/exercism/problem-specifications/blob/main/exercises/line-up/metadata.toml

(BTW, this is a neat little contribution someone could make to the generator in a separate PR: read the name from that file instead of using "TODO")

Copy link
Contributor Author

@FraSanga FraSanga Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(BTW, this is a neat little contribution someone could make to the generator in a separate PR: read the name from that file instead of using "TODO")

Great idea. As soon as I have time, I'll do the PR for that too.
In the meantime, I'll create an issue so it stays marked and we can remember it. (#1621)

EDIT: precheck keeps failing, but I don't see any problems.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The precheck was failing because the test file wasn't formatted correctly after your changes. I pushed a commit to fix it.

@jiegillet jiegillet self-assigned this Mar 9, 2026
@FraSanga FraSanga requested a review from jiegillet March 10, 2026 09:46
Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you very much :)

@jiegillet jiegillet merged commit 31b41ee into exercism:main Mar 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants