Pre-load attoparsec and megaparsec dependencies
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertseng
approved these changes
Feb 6, 2022
ErikSchierboom
approved these changes
Feb 8, 2022
|
Thanks @mike-barber! |
|
Thanks @ErikSchierboom and @petertseng All looking good - I've tested submitting two iterations of my wordy solution again using megaparsec and attoparsec. The tests are passing now :) |
|
Great to hear! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR to add
attoparsecandmegaparsecto the pre-compiled dependencies, following a discussion in issue #1044.I've verified that the resulting image is able to run the two variations of the wordy problem I had attempted previously.
Please let me know if I should update anything besides
pre-compiled/package.yaml, and I'll be happy to do so. It's my first contribution here, so I'm likely to have missed something.