Luhn: A new test case with odd number of digits #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new positive test case with odd number of digits and non-zero first digit.
Member
|
I think this test has been added to |
Contributor
Author
|
@SleeplessByte That sounds great. @ErikSchierboom pointed me to that. I did that for csharp repo, can you point me to the test generator for this repo? |
Contributor
Author
|
Is there any guide for kotlin repo like there is for csharp? exercism/csharp#1543 |
Member
|
@fahadhk I don't think there is. I could be wrong though. |
…t case under consideration for Luhn problem
…rovided in problem-specifications
Contributor
Author
|
Hey @SleeplessByte, a fellow maintainer suggested these changes to me in slack. Can you please have a look. Cheers |
SleeplessByte
approved these changes
Oct 28, 2021
Member
SleeplessByte
left a comment
SleeplessByte
left a comment
There was a problem hiding this comment.
This looks great. Thank you very much @fahadhk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new positive test case with odd number of digits and non-zero first digit.
I have seen a solution in Golang which passes all the tests for Luhn containing odd number of digits and never reads the first digit.
It happens because in all such cases the first digit is zero . I am sure it is also relevant for Kotlin as well.