Add saddle points practice exercise #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keiravillekode
approved these changes
Sep 10, 2024
glennj
reviewed
Sep 10, 2024
|
|
||
| local function render_matrix(matrix) | ||
| return table.concat(map(matrix, function(row) | ||
| return '{' .. table.concat(row, ', ') .. '}, --' |
There was a problem hiding this comment.
Curious, is there a reason for the line-ending comment here?
There was a problem hiding this comment.
Sorry, I meant to leave a comment on this. This prevents the formatter from putting all of the rows of the matrix on the same line. It's basically a hack that lets me avoid adding comments to turn the formatter on and off.
There was a problem hiding this comment.
This is great work. The generated spec is beautiful.
glennj
approved these changes
Sep 10, 2024
keiravillekode
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also extended the test generator to allow test helpers to be included so that I could implement an order-independent comparison for the result set.