Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package set and sync with track #56

Merged
merged 4 commits into from
Mar 18, 2025

Conversation

FranklinChen
Copy link
Contributor

@FranklinChen FranklinChen commented Feb 3, 2025

@FranklinChen FranklinChen requested a review from a team as a code owner February 3, 2025 14:56
Copy link

github-actions bot commented Feb 3, 2025

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our guardians team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/guardians)

@SleeplessByte SleeplessByte reopened this Feb 3, 2025
@SleeplessByte SleeplessByte changed the title Update package set and sync with https://github.com/exercism/purescript/tree/main/template Update package set and sync with track Feb 3, 2025
@SleeplessByte
Copy link
Member

I've edited your message so the url becomes a link @FranklinChen

Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain this PR please?

@SleeplessByte
Copy link
Member

Ah. I assume it was meant to be in sync with exercism/purescript#312?

@SleeplessByte
Copy link
Member

DO NOT MERGE until exercism/purescript#312 passes.

@SleeplessByte
Copy link
Member

@FranklinChen
Copy link
Contributor Author

So I updated the Dockerfile to prevent apt-get install failures but I'm still confused by the error message

docker: Error response from daemon: pull access denied for exercism/test-runner, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.

and don't understand what is going on with that and wonder if it will still happen.

@SleeplessByte
Copy link
Member

Myeah it may be because of the earlier lines of git and libncurses5 not being found.

I don't get it either because:

...match exactly.

Any ideas @ErikSchierboom ?

@ErikSchierboom
Copy link
Member

2.962 E: Version '1:2.30.2-1' for 'git' was not found
2.962 E: Version '6.2+20201114-2' for 'libncurses5' was not found

That's what I get when I run ./bin/run-tests-in-docker.sh

The docker login error is there because the local build failed and Docker will then try to download the image from Docker hub, which requires one to be logged in.

@FranklinChen
Copy link
Contributor Author

Ugh, I forgot to push my commit yesterday that fixes that, just did it now.

@SleeplessByte
Copy link
Member

Thanks for checking Erik!

@FranklinChen
Copy link
Contributor Author

Hopefully with my latest changes I've synced everything that needed to be synced.

@FranklinChen
Copy link
Contributor Author

I think my forks of the purescript-test-runner and purescript repos are ready finally!

@FranklinChen
Copy link
Contributor Author

exercism/purescript@63b8fd6 is already in so I'm just waiting for the test runner to be updated.

@SleeplessByte SleeplessByte merged commit df35f5c into exercism:main Mar 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants