-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package set and sync with track #56
Conversation
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
Hello 👋 Thanks for your PR. This repo does not currently have dedicated maintainers. Our guardians team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed. If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track. Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum. (cc @exercism/guardians) |
I've edited your message so the url becomes a link @FranklinChen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain this PR please?
Ah. I assume it was meant to be in sync with exercism/purescript#312? |
DO NOT MERGE until exercism/purescript#312 passes. |
…d pinning versions.
So I updated the Dockerfile to prevent
and don't understand what is going on with that and wonder if it will still happen. |
Myeah it may be because of the earlier lines of I don't get it either because: ...match exactly. Any ideas @ErikSchierboom ? |
That's what I get when I run The docker login error is there because the local build failed and Docker will then try to download the image from Docker hub, which requires one to be logged in. |
Ugh, I forgot to push my commit yesterday that fixes that, just did it now. |
Thanks for checking Erik! |
Hopefully with my latest changes I've synced everything that needed to be synced. |
I think my forks of the purescript-test-runner and purescript repos are ready finally! |
exercism/purescript@63b8fd6 is already in so I'm just waiting for the test runner to be updated. |
https://github.com/exercism/purescript/tree/main/template
See: exercism/purescript#312