Port to spago from bower/pulp #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade to PureScript 0.13.8 * Introduce spago and get it working in a sandboxed environment * Remove bower/pulp * Documentation * Removed colorized output (will reintroduce later) * Refactor Dockerfile and bin/* scripts
ErikSchierboom
approved these changes
May 26, 2021
There was a problem hiding this comment.
Excellent work! Colorization can indeed be added later.
Once this is merged, the status.test_runner property in the track's config.json file should be set to true (see https://github.com/exercism/purescript/blob/main/config.json#L7) and to add a test_runner.average_run_time property. See https://github.com/exercism/csharp/blob/main/config.json#L19.
| @@ -3,7 +3,7 @@ | |||
| The Docker image for automatically run tests on PureScript solutions submitted | |||
| to [exercism][web-exercism]. | |||
|
|
|||
| This repository contains the Java test runner, which implements the | |||
| This repository contains the PureScript test runner, which implements the | |||
| @@ -15,3 +15,22 @@ To run a solution's test in the Docker container, do the following: | |||
|
|
|||
| [test-runner-interface]: https://github.com/exercism/automated-tests/blob/master/docs/interface.md | |||
| [web-exercism]: https://exercism.io/ | |||
|
|
|||
|
|
|||
| ## Design Goal and Implementation | |||
There was a problem hiding this comment.
Great to have this explanation!
Comment on lines
+43
to
+45
| --mount type=bind,source="${input_dir}",destination=/solution \ | ||
| --mount type=bind,source="${output_dir}",destination=/output \ | ||
| --mount type=tmpfs,destination=/tmp \ |
There was a problem hiding this comment.
I like the added explicitness!
Prevent sending unrelated files to the docker daemon as part of the build context.
|
@emiel Do you have merge permissions? |
|
@ErikSchierboom I do not. :) |
|
Merged :) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After lots of fooling around I've finally got this working. Let me know if I anything needs further clarification.
The PureScript exercises have been ported to Spago as well (exercism/purescript#185) and are awaiting this PR to be approved and merged.
I'm hoping some improvements can be made to spago so that we can simplify some of the steps needed here. There are already some outstanding tickets that would aid us here and I'll follow up with those soon.