-
-
Notifications
You must be signed in to change notification settings - Fork 33
Port to spago (CI) #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to spago (CI) #181
Conversation
Here is an example of a CI run: https://github.com/emiel/purescript/runs/2442322095?check_suite_focus=true |
uses: purescript-contrib/setup-purescript@main | ||
with: | ||
purescript: ${{ matrix.version }} | ||
spago: "0.19.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pin spago to "0.19.2" because later versions don't appear to run the tests. :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be good to include in the documentation :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been resolved in 0.20.2 and is no longer an issue.
@emiel Thank you 💙 |
The travis is failing because it's still using the old configlet |
Thanks for having a look @SleeplessByte. It is my understanding Excercism is migrating completely to GitHub CI and thus that is where my focus is now. I'd rather tackle configlet in another PR because I guess there is more work to do there. ;) |
Totally. It was mostly informational and why I approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know anytthing about purescript or dhall, but it looks good to me!
I concur |
Closing in favor of #185 |
Here is my attempt to continue with the work done here #127 in replacing bower/pulp with spago. I focused on getting CI setup to build and test the exercises (just practice exercises for now). The approach is more or less similar to what was being done for bower. Spago uses two files
packages.dhall
(defines package-set) andspago.dhall
(project dependencies).Please have a look (the last commit contains the interesting bits) and see if you think this approach is worth pursuing. If so I can continue to update the docs and add the finishing touches.
NOTE: Without sharing the
output
and.spago
directories the CI run takes around 7 minutes...@connorads @aimorris