Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added initial dat support #1333

Closed
wants to merge 9,297 commits into from
Closed

Added initial dat support #1333

wants to merge 9,297 commits into from

Conversation

RangerMauve
Copy link
Collaborator

@RangerMauve RangerMauve commented Jul 18, 2019 •
edited
Loading

Supports loading URLs from the dat:// protocol.

You can test it out with

exokit -x webvr dat://55861001e843ad2a0d0c1e1274c07cbc4fffa0a7cd83648741bc93c55c027acf/index.html
  • Ensures that all protocols get a :// after the protocol
  • Adds dat-fetch to the protocols list
  • Adds dat to the list f protocols to normalize

TODO:

  • Figure out how to get the Dat libraries to work without process.nextTick
  • Have the regex which detects protocols pull from the list of protocols in fetch.js?
  • Configure persistent storage for Dat archives

Closes #1213

Avaer Kazmer added 30 commits July 3, 2019 13:11
Merge pull request #1266 from exokitxr/xhr-accessors
8a4cc82 
Make XMLHttpRequest accessors enumerable
Add document.URL
41c4318
Merge pull request #1268 from exokitxr/document-url
a9b1f2a 
Add document.URL
Add WebGL 2 getInternalformatParameter method
8e59777
Add null check for WebGL 2 bindBufferBase method
cd10ee1
Add null check for WebGL 2 bindSampler method
13c697a
Bugfix WebGL 2 bindSampler null check
25609ff
Merge pull request #1272 from exokitxr/webgl2-null
a9aeda7 
WebGL 2 null checks
Add WebGL 2 texStorage3D method
5dda830
Merge pull request #1270 from exokitxr/getinternalformatparameter
2eb0268 
Add WebGL 2 getInternalformatParameter method
Merge pull request #1273 from exokitxr/texstorage3d
5de7465 
Add WebGL 2 texStorage3D method
Small WebGL code moving
3c078e2
Add 3D tex image support
34d3cdd
Add 3D compressed tex image support
71dc9d3
Add WebGL2 getProgramParameter arguments support
c7ce720
Merge pull request #1277 from exokitxr/getprogramparameter
7ab0d4b 
Add WebGL2 getProgramParameter arguments support
Merge branch 'master' into webgl2-texture
68d1ad0
Bugfix getProgramParameter update lost in merge
7e68ae3
Globalize performance object in web workers as well
9045359
Merge pull request #1282 from exokitxr/performance-global
b3585bf 
Globalize performance object in web workers as well
Merge branch 'master' into webgl2-texture
8bc0780
Clean up webgl.cc declarations order
5d57a60
Add webgl.cc templates inlining
09c7654
Bump window-fetch version
a90b68b
Bump window-xhr version
7b102e6
Add file protocol to fetch.js default protocols list
bd3daa4
Merge pull request #1284 from exokitxr/fetch-stream
35430cb 
Bugfix file streaming
Clean up WebGL toGLuint function name
0341aac
More WebGL code build rearrangement bugfixing
3339c6c
Merge branch 'master' into webgl2-texture
86b08fc
Avaer Kazmer and others added 16 commits July 17, 2019 11:12
Spacing cleanup
f877fb0
Block attached listeners from firing during initial Body children attach
e2f996a
Default HTMLIFrameElement child window hiddenness to d 3
1dbdfb6
Remove dead global _fetch method
97ba792
Remove dead utils.js requires
ee1823f
Merge pull request #1255 from exokitxr/script-module
d96da7f 
Support <script type="module">
Merge pull request #1327 from exokitxr/dimension
b8b06a1 
Default HTMLIFrameElement child window hiddenness to d 3
Add EGL hasCurrentContext method
4fe9913
Add EGL getCurrentContext method
e1e6860
Add GLFW hasCurrentContext method
bef5b15
Add GLFW getCurrentContext method
5e05adb
Forward contextless unhandleable local syncs in Window.js
892d0fa
Add GLFW movementX/movementY tracking
c00a164
Merge pull request #1330 from exokitxr/sync-contextless
c147cce 
Sync contextless 2d iframes
Merge pull request #1331 from exokitxr/mouse-movement
42220f1 
Add GLFW movementX/movementY tracking
@RangerMauve
Added initial dat support
dd6809c
@RangerMauve RangerMauve requested a review from avaer July 18, 2019 03:43
@shawwn
Copy link
Contributor

shawwn commented Jul 18, 2019

I spent weeks arguing for decentralization in the context of webXR, and modulesio said it was dumb and highly unlikely. Yet here we are.

+1, hope this gets merged.

@avaer
Copy link
Member

avaer commented Jul 19, 2019

Thanks for bootstrapping this experimentation @RangerMauve!

@avaer
Copy link
Member

avaer commented Jul 19, 2019

@shawwn please review https://github.com/exokitxr/exokit/blob/master/CODE_OF_CONDUCT.md.

The Exokit Github repo is not the place for taking up personal issues with contributors.

@exokitxr exokitxr deleted a comment from shawwn Jul 19, 2019
@exokitxr exokitxr deleted a comment from shawwn Jul 19, 2019
@exokitxr exokitxr deleted a comment from shawwn Jul 19, 2019
@avaer
Copy link
Member

avaer commented Jul 20, 2019

These comments are not related to Mauve’s pull request. Can we take this to another channel?

@avaer avaer closed this Aug 5, 2019
@avaer
Copy link
Member

avaer commented Aug 5, 2019

Sorry @RangerMauve, this one got accidentally closed with a force-push. Did you want to re-open it? 🙏

@RangerMauve
Copy link
Collaborator Author

Yeah! Re-opening would be nice. I can't do it myself though. Otherwise I can open a new PR once I've made more progress. 😁

@exokitxr exokitxr deleted a comment from shawwn Aug 6, 2019
@avaer avaer mentioned this pull request Aug 6, 2019
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avaer avaer Awaiting requested review from avaer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for custom protocols in resource loader
4 participants
@RangerMauve @shawwn @avaer @machenmusik