Skip to content

updated validation to not use question name #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

updated validation to not use question name #116

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ae683dc
updated validation to not use question name
IanEisenberg May 4, 2016
052d555
fixed validation. Besides fixing the update to validation to not incl…
IanEisenberg May 4, 2016
012b046
escaped offending quotation marks
IanEisenberg May 6, 2016
f7a3bed
actually triple quote syntax is probably better
IanEisenberg May 6, 2016
482dcfe
changed quotation use again to work
IanEisenberg May 6, 2016
fc6e788
Merge branch 'master' into validation_update
IanEisenberg May 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion expfactory/survey.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,9 +313,10 @@ def parse_validation(required_counts):
validation = "%s if ( state.stepIndex === %s ) {\n" %(validation,page_number)
else:
validation = "%s else if ( state.stepIndex === %s ) {\n" %(validation,page_number)
validation = "%s if (($.unique($('.page%s.required[type=number],.page3.required:text').map(function(){return this.name})).map(function() {return $('[name*=' + this + '].required[type=number], [name*=' + this + '].required:text').filter(function() { return $(this).val();}).length > 0}).get().indexOf(false) != -1) || ($.unique($('.page%s.required:not([type=number]):not(:text)').map(function(){return this.name})).map(function() {return $('[name*=' + this + '].required:checked').length > 0}).get().indexOf(false) != -1)){\nis_required($('.page%s.required:not(checked)'));\nreturn false;\n" % (validation, page_number, page_number, page_number)
validation = '%s if (($.unique($(`.page%s.required[type=number],.page%s.required:text`).map(function(){return $(this).attr(`meta-text`)})).map(function() {return $(`[meta-text*="` + this + `"].required[type=number], [meta-text*="` + this + `"].required:text`).filter(function() { return $(this).val();}).length > 0}).get().indexOf(false) != -1) || ($.unique($(`.page%s.required:not([type=number]):not(:text)`).map(function(){return $(this).attr(`meta-text`)})).map(function() {return $(`[meta-text*="` + this + `"].required:checked`).length > 0}).get().indexOf(false) != -1)){\nis_required($(`.page%s.required:not(checked)`));\nreturn false;\n' % (validation, page_number, page_number, page_number, page_number)



# If we are at the last page, passing validation should enable the submit
if page_number == pages[-1]:
validation = '%s } else {\nexpfactory_finished=true;\n' %(validation)
Expand Down