fix: update embedding extraction to use appropriate async method #2068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
- Fixed path filters to use correct directory structure (ragas/src/ragas/** instead of src/ragas/**) - Updated installation commands to install from ./ragas subdirectory - Fixed test path to use ragas/tests/unit - Corrected workflow filename reference from ci.yml to ci.yaml - Updated experimental path filter to use experimental/ragas_experimental/** This should resolve the issue where Python tests were being skipped in PRs. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
dosubot
bot
added
size:M
- Fix E402 import order errors in cost.ipynb notebooks by moving imports to top of cells - Fix F821 undefined name error in helicone.ipynb by defining HELICONE_API_KEY variable - Fix F821 undefined name error in openlayer.ipynb by importing openlayer module This resolves the codestyle_check CI failures. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
dosubot
bot
added
size:L
- Fix Haystack import paths to use correct module structure for newer versions - Fix circular import between metrics/base.py and utils.py by using string annotation - Add type cast for optimizer.metric assignment to resolve Self type issue This resolves all pyright type errors in the CI. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Fix pyright working directory: run from ragas/ subdirectory so it correctly resolves module paths - This resolves the module path conflict: ragas.src.ragas.* vs ragas.* - Complete Haystack import fixes in __repr__ methods that were missed earlier - Remove the type cast workaround that's no longer needed Root cause: pyright was scanning ragas/src/ragas from wrong working directory, causing incorrect module path resolution in monorepo structure. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
This file is auto-generated by setuptools-scm and should not be committed. It's already in .gitignore but was accidentally committed.
The path was missing the ragas/ prefix. Should be: - ragas/src/ragas/_version.py (fixed) - experimental/ragas_experimental/_version.py (was already correct) This ensures the auto-generated version files are properly ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embedding extraction should be async and use langchain's
embed_textmethod rather thanembed_query