Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] lowercase urls, add more pretty prints #2909

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[eas-cli] lowercase urls, add more pretty prints #2909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4df598c
[eas-cli] lowercase urls, add more pretty prints
quinlanj Feb 14, 2025
5f04355
Temporary Commit at 2/14/2025, 12:38:47 PM
quinlanj Feb 14, 2025
03a2e87
Temporary Commit at 2/14/2025, 12:41:29 PM
quinlanj Feb 14, 2025
ccfa0f7
Temporary Commit at 2/21/2025, 12:17:24 PM
quinlanj Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ This is the log of notable changes to EAS CLI and related packages.

- Narrow amount of data queried for basic update channel operations. ([#2901](https://github.com/expo/eas-cli/pull/2901) by [@wschurman](https://github.com/wschurman))
- Fix `eas fingerprint:compare` description. ([#2908](https://github.com/expo/eas-cli/pull/2908) by [@quinlanj](https://github.com/quinlanj))
- Fix `eas fingerprint:compare` URL generation and pretty prints. ([#2909](https://github.com/expo/eas-cli/pull/2909) by [@quinlanj](https://github.com/quinlanj))

## [15.0.10](https://github.com/expo/eas-cli/releases/tag/v15.0.10) - 2025-02-11

Expand Down
9 changes: 6 additions & 3 deletions packages/eas-cli/src/commands/fingerprint/compare.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ export default class FingerprintCompare extends EasCommand {

const project = await AppQuery.byIdAsync(graphqlClient, projectId);
const fingerprintCompareUrl = new URL(
`/accounts/${project.ownerAccount.name}/projects/${project.name}/fingerprints/compare`,
`/accounts/${project.ownerAccount.name}/projects/${project.slug}/fingerprints/compare`,
getExpoWebsiteBaseUrl()
);
fingerprintCompareUrl.searchParams.set('a', firstFingerprintInfo.fingerprint.hash);
Expand Down Expand Up @@ -528,7 +528,7 @@ async function getFingerprintInfoFromUpdateGroupIdOrUpdateIdAsync(
const project = await AppQuery.byIdAsync(graphqlClient, projectId);
const updateUrl =
getExpoWebsiteBaseUrl() +
`/accounts/${project.ownerAccount.name}/projects/${project.name}/updates/${maybeUpdateGroupId}`;
`/accounts/${project.ownerAccount.name}/projects/${project.slug}/updates/${maybeUpdateGroupId}`;
throw new Error(
`Please pass in your update ID from ${updateUrl} or use interactive mode to select the update ID.`
);
Expand Down Expand Up @@ -739,7 +739,10 @@ const PRETTY_CONTENT_ID: Record<string, string> = {
'expoAutolinkingConfig:ios': 'Expo autolinking config (iOS)',
'expoAutolinkingConfig:android': 'Expo autolinking config (Android)',
'packageJson:scripts': 'package.json scripts',
expoConfig: 'Expo config',
expoConfig: 'Expo app config',
'package:react-native': 'React Native package.json',
'rncoreAutolinkingConfig:ios': 'React Native Community autolinking config (iOS)',
'rncoreAutolinkingConfig:android': 'React Native Community autolinking config (Android)',
};

function printContentSource({
Expand Down