[worker] Add worker from turtle-v2 #3268

sjchmiela · 2025-11-28T15:00:40Z

Why

We want to streamline DX of the worker part of EAS. Part of it is colocating all code in one repository.

How

Copied code over to eas-cli. Adjusted code — each commit represents a single piece of work towards adjusting code to this repository. The main changes are around removing dependency on turtle-v2 internal libraries.

One thing to figure out still is deployment process. I've added build-and-deploy-worker which is capable of deploying to staging and production. The question is how to automate it. In turtle-v2 we have system tests. Should we just copy them over to here? (Don't like that.) Should we streamline system tests now and instead of having this weird turtle-v2-example repo, create project on the go? Should we deploy worker manually for now?

I think I'd rather deploy manually for now?

Test Plan

Deployed worker to staging. Ran system tests. They succeeded!! https://github.com/expo/turtle-v2/actions/runs/20042956545/job/57535011098

We'll source `.direnv/test` secrets in CI directly

github-actions · 2025-11-28T15:23:35Z

Size Change: +82 kB (+0.15%)

Total Size: 55 MB

Filename	Size	Change
`./packages/eas-cli/dist/eas-linux-x64.tar.gz`	55 MB	+82 kB (+0.15%)

_{compressed-size-action}

# This is the 1st commit message: Use `GCS` from `@expo/build-tools` # The commit message #2 will be skipped: # fixup! Use `GCS` from `@expo/build-tools`

codecov · 2025-11-28T15:55:50Z

Codecov Report

❌ Patch coverage is 16.62674% with 1740 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.25%. Comparing base (4476c87) to head (ddd58e4).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...kages/worker/src/__integration__/stateSync.test.ts	0.00%	187 Missing ⚠️
packages/worker/src/service.ts	0.00%	150 Missing and 13 partials ⚠️
...ages/worker/src/__integration__/abortBuild.test.ts	0.00%	126 Missing ⚠️
.../src/__integration__/possiblyHangingWorker.test.ts	0.00%	96 Missing ⚠️
packages/worker/src/env.ts	0.00%	71 Missing and 14 partials ⚠️
packages/worker/src/external/analytics.ts	19.82%	80 Missing and 5 partials ⚠️
packages/worker/src/runtimeEnvironment.ts	50.96%	74 Missing and 3 partials ⚠️
packages/worker/src/displayRuntimeInfo.ts	0.00%	66 Missing and 6 partials ⚠️
packages/worker/src/upload.ts	60.51%	59 Missing and 3 partials ⚠️
packages/worker/src/utils/WebSocketServer.ts	0.00%	59 Missing and 3 partials ⚠️
... and 26 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3268      +/-   ##
==========================================
- Coverage   51.90%   49.25%   -2.64%     
==========================================
  Files         632      670      +38     
  Lines       25874    27984    +2110     
  Branches     5438     5765     +327     
==========================================
+ Hits        13427    13781     +354     
- Misses      11327    13013    +1686     
- Partials     1120     1190      +70

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-12-10T13:54:06Z

Subscribed to pull request

File Patterns	Mentions
*/	@douglowder

Generated by CodeMention

hSATAC

Looks good to me overall, but I’ll let Doug give the final approval since he owns this code.

packages/expo-cocoapods-proxy/expo-cocoapods-proxy.gemspec

hSATAC · 2025-12-11T07:49:57Z

packages/worker/src/__integration__/utils/jobs.ts

+    provisioningProfileBase64: 'MjEzNwo=',
+    distributionCertificate: {
+      dataBase64: 'MjEzNwo=',
+      password: 'dominiksokal',


Just to confirm this is a dummy credential right?

yea definitely. cc @dsokal your legacy lives on

Confirmed. A dummy credential :)

@sjchmiela try decoding the base64 ;)

hSATAC · 2025-12-11T07:52:34Z

.github/workflows/build-and-deploy-worker.yml

+          for platform in android ios; do
+            GCP_TARBALL="worker-$platform-sha1-$GITHUB_SHA.tar.gz"
+
+            if ! gsutil stat gs://eas-build-worker-tarballs/$GCP_TARBALL; then


It appears this is the first time gs://eas-build-worker-tarballs has been publicly exposed.
I reviewed the bucket’s access policy and it looks safe.

Adding a note here as this does expand our attack surface.

github-actions · 2025-12-12T15:59:57Z

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

douglowder

Looks good -- thanks for the careful organization of commits!

sjchmiela added 6 commits November 28, 2025 14:32

Copy files to here

1f37073

Update package.json and yarn.lock

32a962d

Add @expo/rudder-sdk-node

5592847

Fix tsconfig.json

4c077fb

Simplify direnv setup

c6d9d29

We'll source `.direnv/test` secrets in CI directly

Remove obsolete assets

1b4f54b

sjchmiela force-pushed the stanley/move-worker-to-here branch from ac763be to 5e00ef2 Compare November 28, 2025 15:03

sjchmiela added the no changelog PR that doesn't require a changelog entry label Nov 28, 2025

sjchmiela force-pushed the stanley/move-worker-to-here branch from e509d68 to 833de30 Compare November 28, 2025 15:40

sjchmiela added 14 commits November 28, 2025 16:45

# This is a combination of 2 commits.

5440683

# This is the 1st commit message: Use `GCS` from `@expo/build-tools` # The commit message #2 will be skipped: # fixup! Use `GCS` from `@expo/build-tools`

Fix getAccessedEnvs, env and Environment

cdeb971

Import test utils

43cea47

Migrate from promise.sleep to timers/promises

58d8f0d

Remove notion of priority

72fdfd7

Fix Sentry integration

b297c48

Import ResourceClass and image info

bb8e6c2

Remove ExitHandler

a9105e7

Import errorMiddleware

4b89ce8

Import WebSocketServer

9ff4f38

Import LauncherMessage, WorkerMessage and Worker

403b9b7

Import logger

ffc2330

Import turtleFetch

aa0aa3f

Fix .eslintrc.json

91e3d4b

sjchmiela force-pushed the stanley/move-worker-to-here branch 2 times, most recently from d07514d to 6fd3287 Compare November 28, 2025 15:50

sjchmiela added 3 commits November 28, 2025 21:14

Add dependencies missing from package.json

4655b36

Adjust code for missing no-floating-promises ESLint rule

b91734a

Adjust .eslintrc.js

a3ccfe3

Adjust package.sh

5f4feab

sjchmiela force-pushed the stanley/move-worker-to-here branch from 73c547b to 94c4f9c Compare November 28, 2025 20:15

Fixup setup-gcloud

6bf9ac6

sjchmiela force-pushed the stanley/move-worker-to-here branch from 94c4f9c to 6bf9ac6 Compare December 1, 2025 09:35

Bump packages

a1b31a4

sjchmiela force-pushed the stanley/move-worker-to-here branch 3 times, most recently from a132a7b to 9970a4a Compare December 9, 2025 10:18

sjchmiela added 4 commits December 9, 2025 12:47

Fix GCP authentication means

a11fbec

Fix src/services/worker/dist expectation from launcher

2f0597c

Apply #2434 from turtle-v2

a7941e7

Apply #2436 from turtle-v2

34c41d8

sjchmiela force-pushed the stanley/move-worker-to-here branch 2 times, most recently from c427bac to b8047fd Compare December 9, 2025 11:48

sjchmiela added 3 commits December 9, 2025 12:50

Add worker.yml

d53a6ba

Cleanup .envrc

08f17c3

Use real secrets for integration tests

9708f23

sjchmiela force-pushed the stanley/move-worker-to-here branch from b8047fd to 9708f23 Compare December 9, 2025 15:43

sjchmiela added 2 commits December 10, 2025 10:15

Move Environment to constants

65911d9

Fix abortBuild test

64d8dfa

sjchmiela marked this pull request as ready for review December 10, 2025 13:53

sjchmiela requested review from douglowder and hSATAC December 10, 2025 13:53

sjchmiela requested a review from randomhajile December 10, 2025 13:54

hSATAC reviewed Dec 11, 2025

View reviewed changes

sjchmiela and others added 2 commits December 11, 2025 22:23

Update packages/expo-cocoapods-proxy/expo-cocoapods-proxy.gemspec

817e256

Fixup

ddd58e4

douglowder approved these changes Dec 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[worker] Add worker from turtle-v2 #3268

[worker] Add worker from turtle-v2 #3268

Uh oh!

sjchmiela commented Nov 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 28, 2025 •

edited

Loading

Uh oh!

codecov bot commented Nov 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 10, 2025

Uh oh!

hSATAC left a comment

Uh oh!

Uh oh!

hSATAC Dec 11, 2025

Uh oh!

sjchmiela Dec 11, 2025

Uh oh!

dsokal Dec 11, 2025

Uh oh!

dsokal Dec 11, 2025

Uh oh!

hSATAC Dec 11, 2025

Uh oh!

github-actions bot commented Dec 12, 2025

Uh oh!

douglowder left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[worker] Add worker from turtle-v2 #3268

Are you sure you want to change the base?

[worker] Add worker from turtle-v2 #3268

Uh oh!

Conversation

sjchmiela commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

How

Test Plan

Uh oh!

github-actions bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Dec 10, 2025

Uh oh!

hSATAC left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hSATAC Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

sjchmiela Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

dsokal Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

dsokal Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

hSATAC Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 12, 2025

Uh oh!

douglowder left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sjchmiela commented Nov 28, 2025 •

edited

Loading

github-actions bot commented Nov 28, 2025 •

edited

Loading

codecov bot commented Nov 28, 2025 •

edited

Loading