Skip to content

Conversation

@quinlanj
Copy link
Member

@quinlanj quinlanj commented Dec 20, 2025

Why

Convert channel deletion to a background job instead of synchronous deletion, analogous to #3258

How

  • Implemented a new background job-based channel deletion flow:
    • Added scheduleUpdateChannelDeletion mutation
    • Created a new delete.ts module with scheduleChannelDeletionAsync function
    • Updated the channel delete command to use the new background job approach
    • Added polling for job completion

Test Plan

  • Create a channel with EXPO_DEBUG=1 eas-dev channel:create
  • delete channel with: EXPO_DEBUG=1 eas-dev channel:delete, ensure successful receipt
  • ensure successful deletion: eas-dev channel:list, make sure channel we just deleted is absent

@github-actions
Copy link

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link

Size Change: -1.14 kB (0%)

Total Size: 54.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 54.9 MB -1.14 kB (0%)

compressed-size-action

@quinlanj quinlanj requested a review from wschurman December 20, 2025 00:23
@quinlanj quinlanj marked this pull request as ready for review December 20, 2025 00:23
@codecov
Copy link

codecov bot commented Dec 20, 2025

Codecov Report

❌ Patch coverage is 81.57895% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.98%. Comparing base (aabf519) to head (971f930).

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/channel/delete.ts 33.34% 4 Missing ⚠️
packages/eas-cli/src/channel/delete.ts 57.15% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3278      +/-   ##
==========================================
+ Coverage   51.93%   51.98%   +0.05%     
==========================================
  Files         634      635       +1     
  Lines       25931    25961      +30     
  Branches     5451     5457       +6     
==========================================
+ Hits        13464    13492      +28     
- Misses      11345    11347       +2     
  Partials     1122     1122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @douglowder
packages/eas-cli/src/channel/** @wschurman
packages/eas-cli/src/commands/channel/** @wschurman

Generated by CodeMention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants