chore: add CI check for needing to run ctix #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 20, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## @wschurman/02-20-feat_default_all_loaders_and_mutators_to_enforcing #258 +/- ##
=====================================================================================================
Coverage 100.00% 100.00%
=====================================================================================================
Files 80 80
Lines 2071 2071
Branches 285 285
=====================================================================================================
Hits 2071 2071
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wschurman
force-pushed
the
@wschurman/02-20-chore_add_ci_check_for_needing_to_run_ctix
branch
2 times, most recently
from
63622df to
09f813c
Compare
wschurman
force-pushed
the
@wschurman/02-20-chore_add_ci_check_for_needing_to_run_ctix
branch
from
09f813c to
8d86164
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
#255 switched barreling to
ctixand fully-automated it (no manual intervention). But the intention is still to have the author run the command when they add new files in case they don't want the new files to be exported in the barrel.This PR adds a CI step to ensure that the barrels are up to date.
How
Run
yarn ctixand check if working directory is dirty. If so, fail the CI run.Test Plan
Blah.ts, in src. Don't runyarn ctix.