perf: remove argument reassignment

HISTORY.md

@@ -23,6 +23,7 @@ unreleased
     - deps: mime-types@~2.1.1
     - perf: reduce try block size
     - perf: remove bitwise operations
+  * perf: remove argument reassignment
 
 1.12.4 / 2015-05-10
 ===================

index.js

@@ -1,11 +1,12 @@
 /*!
  * body-parser
- * Copyright(c) 2014 Douglas Christopher Wilson
+ * Copyright(c) 2014-2015 Douglas Christopher Wilson
  * MIT Licensed
  */
 
 /**
  * Module dependencies.
+ * @private
  */
 
 var deprecate = require('depd')('body-parser')
@@ -67,18 +68,18 @@ fs.readdirSync(parsersDir).forEach(function onfilename(filename) {
  * @param {object} [options]
  * @return {function}
  * @deprecated
- * @api public
+ * @public
  */
 
 function bodyParser(options){
   var opts = {}
 
-  options = options || {}
-
   // exclude type option
-  for (var prop in options) {
-    if ('type' !== prop) {
-      opts[prop] = options[prop]
+  if (options) {
+    for (var prop in options) {
+      if ('type' !== prop) {
+        opts[prop] = options[prop]
+      }
     }
   }
 

lib/read.js

@@ -94,15 +94,18 @@ function read(req, res, next, parse, debug, options) {
     }
 
     // parse
+    var str
     try {
       debug('parse body')
-      body = typeof body !== 'string' && encoding !== null
+      str = typeof body !== 'string' && encoding !== null
         ? iconv.decode(body, encoding)
         : body
-      req.body = parse(body)
+      req.body = parse(str)
     } catch (err) {
       if (!err.status) {
-        err.body = body
+        err.body = str === undefined
+          ? body
+          : str
         err.status = 400
       }
       return next(err)

lib/types/json.js

@@ -44,16 +44,16 @@ var firstcharRegExp = /^[\x20\x09\x0a\x0d]*(.)/
  */
 
 function json(options) {
-  options = options || {}
-
-  var limit = typeof options.limit !== 'number'
-    ? bytes.parse(options.limit || '100kb')
-    : options.limit
-  var inflate = options.inflate !== false
-  var reviver = options.reviver
-  var strict = options.strict !== false
-  var type = options.type || 'application/json'
-  var verify = options.verify || false
+  var opts = options || {}
+
+  var limit = typeof opts.limit !== 'number'
+    ? bytes.parse(opts.limit || '100kb')
+    : opts.limit
+  var inflate = opts.inflate !== false
+  var reviver = opts.reviver
+  var strict = opts.strict !== false
+  var type = opts.type || 'application/json'
+  var verify = opts.verify || false
 
   if (verify !== false && typeof verify !== 'function') {
     throw new TypeError('option verify must be function')

lib/types/raw.js

@@ -28,14 +28,14 @@ module.exports = raw
  */
 
 function raw(options) {
-  options = options || {};
-
-  var inflate = options.inflate !== false
-  var limit = typeof options.limit !== 'number'
-    ? bytes.parse(options.limit || '100kb')
-    : options.limit
-  var type = options.type || 'application/octet-stream'
-  var verify = options.verify || false
+  var opts = options || {};
+
+  var inflate = opts.inflate !== false
+  var limit = typeof opts.limit !== 'number'
+    ? bytes.parse(opts.limit || '100kb')
+    : opts.limit
+  var type = opts.type || 'application/octet-stream'
+  var verify = opts.verify || false
 
   if (verify !== false && typeof verify !== 'function') {
     throw new TypeError('option verify must be function')

lib/types/text.js

@@ -29,15 +29,15 @@ module.exports = text
  */
 
 function text(options) {
-  options = options || {};
-
-  var defaultCharset = options.defaultCharset || 'utf-8'
-  var inflate = options.inflate !== false
-  var limit = typeof options.limit !== 'number'
-    ? bytes.parse(options.limit || '100kb')
-    : options.limit
-  var type = options.type || 'text/plain'
-  var verify = options.verify || false
+  var opts = options || {}
+
+  var defaultCharset = opts.defaultCharset || 'utf-8'
+  var inflate = opts.inflate !== false
+  var limit = typeof opts.limit !== 'number'
+    ? bytes.parse(opts.limit || '100kb')
+    : opts.limit
+  var type = opts.type || 'text/plain'
+  var verify = opts.verify || false
 
   if (verify !== false && typeof verify !== 'function') {
     throw new TypeError('option verify must be function')

lib/types/urlencoded.js

@@ -36,30 +36,30 @@ var parsers = Object.create(null)
  * @api public
  */
 
-function urlencoded(options){
-  options = options || {};
+function urlencoded(options) {
+  var opts = options || {}
 
   // notice because option default will flip in next major
-  if (options.extended === undefined) {
+  if (opts.extended === undefined) {
     deprecate('undefined extended: provide extended option')
   }
 
-  var extended = options.extended !== false
-  var inflate = options.inflate !== false
-  var limit = typeof options.limit !== 'number'
-    ? bytes.parse(options.limit || '100kb')
-    : options.limit
-  var type = options.type || 'application/x-www-form-urlencoded'
-  var verify = options.verify || false
+  var extended = opts.extended !== false
+  var inflate = opts.inflate !== false
+  var limit = typeof opts.limit !== 'number'
+    ? bytes.parse(opts.limit || '100kb')
+    : opts.limit
+  var type = opts.type || 'application/x-www-form-urlencoded'
+  var verify = opts.verify || false
 
   if (verify !== false && typeof verify !== 'function') {
     throw new TypeError('option verify must be function')
   }
 
   // create the appropriate query parser
   var queryparse = extended
-    ? extendedparser(options)
-    : simpleparser(options)
+    ? extendedparser(opts)
+    : simpleparser(opts)
 
   // create the appropriate type checking function
   var shouldParse = typeof type !== 'function'