Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove security file #590

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

bjohansebas
Copy link
Member

@@ -35,7 +35,6 @@
"lib/",
"LICENSE",
"HISTORY.md",
"SECURITY.md",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, this is interesting. I think it is alright to remove the file from the bundle as long as all the ones we do this for also have a repository or homepage linking to the repository. The should, and this one does, but just want to call it out for folks reviewing the other PRs.

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wesleytodd wesleytodd merged commit 5e6dd08 into expressjs:master Feb 20, 2025
11 checks passed
@bjohansebas bjohansebas deleted the remove-security-file branch February 20, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants