Flush alias #74
Closed
Flush alias #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would help me as well - any feedback on this @dougwilson? |
Supports use such as:
```javascript
// Not going to write again for a while. If compression middleware is
// installed let's tell it to flush what we've got through to the client.
if (res.flushCompression) {
res.flushCompression();
}
```
Currently the `res` object has a `flush` method regardless of whether
compression middleware is installed. The built-in `flush` method issues a
noisy deprecation warning. This patch provides an alias for the `flush`
method to allow detection of the compression middleware's `flush`.
This addresses expressjs#72.
|
This would be nice. Any chance of a quick review, @dougwilson? |
|
dougwilson
force-pushed
the
master
branch
3 times, most recently
from
d7bb81b to
cd957aa
Compare
|
I'm not sure about adding this property, I'll ping on Slack in case anyone has feedback to share. cc: @expressjs/express-tc |
|
.flush is no longer a method on HTTP OutgoingMessage, so this method is no longer needed https://nodejs.org/api/deprecations.html#dep0001-httpoutgoingmessageprototypeflush |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This adds
res.flushCompression()as an alias forres.flush()This supports use such as:
Currently the
resobject has aflushmethod regardless of whether compression middleware is installed. The built-influshmethod issues a noisy deprecation warning. This patch provides an alias for theflushmethod to allow detection of the compression middleware'sflush.This addresses #72.
Thanks,
Bo