Skip to content

Commit

Permalink
fix(ci): reorder npm i steps to fix ci for older node versions (#6336)
Browse files Browse the repository at this point in the history
  • Loading branch information
Phillip9587 authored Feb 17, 2025
1 parent 3a5edfa commit 36fb59c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -133,13 +133,13 @@ jobs:
npm config set loglevel error
shell: bash

- name: Install dependencies
run: npm install

- name: Install Node version specific dev deps
if: ${{ matrix.npm-i != '' }}
run: npm install --save-dev ${{ matrix.npm-i }}

- name: Install dependencies
run: npm install

- name: Remove non-test dependencies
run: npm rm --silent --save-dev connect-redis

Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,11 @@
"hbs": "4.2.0",
"marked": "0.7.0",
"method-override": "3.0.0",
"mocha": "10.2.0",
"mocha": "^6.2.2",
"morgan": "1.10.0",
"nyc": "15.1.0",
"nyc": "^14.1.1",
"pbkdf2-password": "1.2.1",
"supertest": "6.3.0",
"supertest": "^6.1.6",
"vhost": "~3.0.2"
},
"engines": {
Expand Down

0 comments on commit 36fb59c

Please sign in to comment.