deps: upgrade supertest #6112
Closed
deps: upgrade supertest #6112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamLizu
approved these changes
Dec 8, 2024
|
There is already a version 7. |
|
@bjohansebas I was trying to target 7.0.0, seems like we will need to some work, based on the CI results |
UlisesGascon
approved these changes
Dec 20, 2024
wesleytodd
reviewed
Jan 8, 2025
| @@ -78,7 +78,7 @@ | |||
| "morgan": "1.10.0", | |||
| "nyc": "15.1.0", | |||
| "pbkdf2-password": "1.2.1", | |||
| "supertest": "6.3.0", | |||
| "supertest": "6.3.4", | |||
There was a problem hiding this comment.
Can we just unpin this (^)? I thought we agreed to just unpin all these as we touched them?
sheplu
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
LGTM but as @wesleytodd said can we ^ the deps but also maybe not update them all one by one
wesleytodd
pushed a commit
that referenced
this pull request
Feb 13, 2025
fix(deps): mocha@^10.7.3 (closes #6121) fix(deps): marked@^15.0.3 (closes #6120) fix(deps): express-session@^1.18.1 (closes #6119) fix(deps): ejs@^3.1.10 (closes #6117) fix(deps): content-type@^1.0.5 (closes #6115) fix(deps): connect-redis@^8.0.1 (closes #6114) fix(deps): supertest@^7.0.0 (closes #6112)
wesleytodd
pushed a commit
that referenced
this pull request
Feb 13, 2025
fix(deps): mocha@^10.7.3 (closes #6121) fix(deps): marked@^15.0.3 (closes #6120) fix(deps): express-session@^1.18.1 (closes #6119) fix(deps): ejs@^3.1.10 (closes #6117) fix(deps): content-type@^1.0.5 (closes #6115) fix(deps): connect-redis@^8.0.1 (closes #6114) fix(deps): supertest@^6.3.4 (closes #6112)
|
I am nearly positive I tried this update and hit the same error a few months ago. I searched but couldnt find the pr/issue. IIRC there is a bug in newer versions of In the new PR I pinned it back to the 6 range. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #6103 (comment)