Feat/poc translate by json - POC - NOT MERGE #1738
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in-menu-getting-started
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
carlosstenzel
changed the title
|
@bjohansebas @chrisdel101 ref: #1736 |
This reverts commit 96eb526.
This reverts commit 1e9e237.
…sstenzel/expressjs.com into feat/poc-translate-by-json
|
BTW, the change of the tool is not only for i18n, it is also to avoid having to focus too much on design/accessibility. Thanks for creating this POC, the way it's working would create layout shifts, which is a bad user experience and Google could/may penalize us for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translation test using JSON, instead of copying files to translate.
modifeld files
_includes/head.html
_includes/header/header.html
_layouts/page.html
assets/js/translations.js
i18n/header.json
i18n/home.json
index.md
Test pages:
header - menu - item (home)
https://deploy-preview-1738--expressjscom-preview.netlify.app/en/starter/installing
https://deploy-preview-1738--expressjscom-preview.netlify.app/pt-br/starter/installing
description only home in EN