Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 9-digit millisecond precision to isoTimestamp #348 #353

Conversation

WtfJoke
Copy link
Contributor

@WtfJoke WtfJoke commented Jan 4, 2024

Fixes #348

Thought I make a suggestion for a potential fix :)

…hiller#348

ISO-8601 does not specify the number of digits in the decimal fraction.

JavaScript `new Date().toISOString()` which is compliant to ISO-8601, has a precision of three digits (miliseconds precision).
Java `Instant.now().toString()` which is compliant to ISO-8601, has a precision of nine digits (nanoseconds precision).

This change will allow timestamps with nanoseconds precision.
@WtfJoke WtfJoke force-pushed the supportIsoTimeStampsUpTo9DigitsPrecision branch from b37eff7 to 89a92d4 Compare January 4, 2024 23:29
@fabian-hiller fabian-hiller self-assigned this Jan 5, 2024
@fabian-hiller fabian-hiller added enhancement New feature or request priority This has priority labels Jan 5, 2024
@fabian-hiller fabian-hiller force-pushed the supportIsoTimeStampsUpTo9DigitsPrecision branch from 110dd5d to 578cd68 Compare January 16, 2024 16:17
@fabian-hiller fabian-hiller merged commit 773ba3a into fabian-hiller:main Jan 16, 2024
1 check passed
@WtfJoke WtfJoke deleted the supportIsoTimeStampsUpTo9DigitsPrecision branch January 16, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority This has priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isoTimestamp only supports decimal fraction up to 3 digits
2 participants