refactor: string schema tests #366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabian-hiller
added
enhancement
ariskemper
force-pushed
the
refactor-string-schema-tests
branch
from
59d3941 to
1e2e2c6
Compare
|
@fabian-hiller ready for review and merge? |
| @@ -83,17 +83,17 @@ describe('stringAsync', () => { | |||
| describe('schema pipeline', () => { | |||
| const schema1 = stringAsync([minLength(2), maxLength(3)]); | |||
|
|
|||
| test('should contain invalid length message, type and requirements', () => { | |||
| test('should expose the pipeline', () => { | |||
There was a problem hiding this comment.
I would refactor that and test the entire schema object for the different arguments.
There was a problem hiding this comment.
@fabian-hiller so you would like to add more tests for using different arguments, validations ( minLength, maxLength, bic, creditCard .... ) or entire schema properties?
There was a problem hiding this comment.
I would not distinguish between different pipeline actions. As you can see in the API reference, string allows you to pass no argument, only a pipeline or a message and a pipeline. I would just test each combination.
fabian-hiller
force-pushed
the
main
branch
7 times, most recently
from
b997a0f to
6d0cde4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.