Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reset camera options for gyro button #2200

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

ceski-1
Copy link
Collaborator

@ceski-1 ceski-1 commented Feb 13, 2025

Fixes #2199

@fabiangreffrath Gyro button set to "Reset Camera" or "Reset / Disable Gyro" might be what you're looking for.

woof0005

@ceski-1 ceski-1 changed the title Gyro reset camera Add reset camera options for gyro button Feb 13, 2025
@fabiangreffrath
Copy link
Owner

Should we really push this into the "Gyro Button Action" item? We could introduce a "Reset Camera on Tap" on/off switch.

@ceski-1
Copy link
Collaborator Author

ceski-1 commented Feb 13, 2025

Should we really push this into the "Gyro Button Action" item? We could introduce a "Reset Camera on Tap" on/off switch.

I looked at the gyro implementations in a few popular multiplayer games and it was always one of these approaches:

  • Separate "Reset Camera" key binding that wouldn't be specific to gyro
  • Shared "Reset Camera (Tap) / Gyro Modifier (Hold)" key binding, sort of like this PR

We're pretty much out of room in both the key bindings menu and the gyro menu so I don't want to add another menu option. What do you think?

@fabiangreffrath
Copy link
Owner

Alright, it's probably a setting that you set once and then forget.

Copy link
Owner

@fabiangreffrath fabiangreffrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ceski-1 ceski-1 merged commit d986f98 into fabiangreffrath:master Feb 13, 2025
8 checks passed
@ceski-1 ceski-1 deleted the gyro_reset_camera branch February 13, 2025 17:22
@ceski-1
Copy link
Collaborator Author

ceski-1 commented Feb 13, 2025

Documentation updated too: https://github.com/fabiangreffrath/woof/wiki/Gamepad#gyro-options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Short click on Gyro button should center view
2 participants