$.fn.val: ensuring it works with “input[type=file][multiple]” elements

fabiospampinato · Sep 6, 2019 · 406bd3d · 406bd3d
1 parent a0d8cbc
commit 406bd3d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/forms/helpers/get_value.ts b/src/forms/helpers/get_value.ts
@@ -4,7 +4,7 @@
 
 function getValue ( ele: Ele ): string | string[] {
 
-  if ( ele.multiple ) return pluck ( filter.call ( ele.options, option => option.selected && !option.disabled && !option.parentNode.disabled ), 'value' );
+  if ( ele.multiple && ele.options ) return pluck ( filter.call ( ele.options, option => option.selected && !option.disabled && !option.parentNode.disabled ), 'value' );
 
   return ele.value || '';
 

diff --git a/test/modules/forms.js b/test/modules/forms.js
@@ -17,6 +17,7 @@ var fixture = '\
       <option value="option-2" selected>Selected</option>\
     </select>\
     <input type="file" name="file" />\
+    <input type="file" name="file-multiple" multiple />\
     <input type="submit" value="submit" name="submit" />\
   </form>\
 ';
@@ -61,6 +62,14 @@ describe ( 'Forms', { beforeEach: getFixtureInit ( fixture ) }, function () {
 
     });
 
+    it ( 'gets the value of input file multiple', function ( t ) {
+
+      var val = $('.form input[type=file][multiple]').val ();
+
+      t.is ( val, '' );
+
+    });
+
     it ( 'gets the value of select', function ( t ) {
 
       var val = $('select[name=select]').val ();