Skip to content

Commit

Permalink
Make vendored json into proper target
Browse files Browse the repository at this point in the history
Summary:
This changes the vendored json module to be a proper target.
This is necessary, since in some places where toolchain applications using json were included in release or otherwise packaged, the json module would be missing. This solves the issue and simplifies internals removing the need to prepend the utility modules path all over the place.

This is first part - that we need to sync back before progressing and using the new application for testing

Reviewed By: TheGeorge

Differential Revision: D65274428

fbshipit-source-id: a92a1dc38cddbaa708093e9a5f8c72c5294b71cb
  • Loading branch information
michalmuskala authored and facebook-github-bot committed Oct 31, 2024
1 parent df95ef0 commit 0ccd057
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions prelude/erlang/toolchain/BUCK.v2
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,21 @@ toolchain_utilities(
],
visibility = ["PUBLIC"],
)

# exported for use in shell & test binary, they have a runtime dependency on json
# can be removed once we're on OTP 27
erlang_application(
name = "toolchain_json",
srcs = ["json.erl"],
applications = [
"kernel",
"stdlib",
],
erl_opts = [
"+deterministic",
"+warnings_as_errors",
],
shell_libs = [],
use_global_parse_transforms = False,
visibility = ["PUBLIC"],
)

0 comments on commit 0ccd057

Please sign in to comment.