Skip to content

Commit

Permalink
bxl: Add fixme
Browse files Browse the repository at this point in the history
Summary: I hit this in a real bxl script :/

Reviewed By: stepancheg

Differential Revision: D61436939

fbshipit-source-id: 7b2c8a3422d1b11bd417cbff05244b124dcb18df
  • Loading branch information
JakobDegen authored and facebook-github-bot committed Aug 18, 2024
1 parent 72a80a5 commit 7084dfb
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions app/buck2_bxl/src/bxl/starlark_defs/target_list_expr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,9 @@ impl<'v> TargetListExpr<'v, ConfiguredTargetNode> {
ConfiguredTargetListArg::TargetList(unpack) => {
let mut resolved = vec![];

// FIXME(JakobDegen): These iterations don't run in parallel, which is pretty sad.
// Unfortunately, that's also not easy to fix because for some reason this code
// prints to console
for item in unpack.items {
let unpacked = Self::unpack_literal(
item,
Expand Down

0 comments on commit 7084dfb

Please sign in to comment.