Rename the root cell
#687
Rename the root cell
#687
Conversation
facebook-github-bot
added
the
CLA Signed
|
Hello @JakobDegen, do you know who I should tag to have a look at this? I'm very open to feedback, especially on the caveats that I outlined. I'd like to remove them, but I don't know what would be a good way. |
|
What about places like this that use an implicit root? https://github.com/facebook/buck2/blob/main/app/buck2_test_runner/BUCK#L18-L21 |
|
I also thought they would have to be made explicit, but as I understand it, a bare |
|
I'm not sure who else to tag, could you point me to the right person @ndmitchell? |
|
Sorry this took so long. This looks fine to me in principle, I'll see what I need to do to get it through CI internally too |
|
@JakobDegen has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Oh, oof, could you rebase this? Otherwise should be easy to get merged |
This commit renames the `root` cell to facilitate embedding it as a dependency to Rust projects. While the Buck2 repository does not have an official public API, depending on it is the most reasonable way of writing custom test runners, which is important for OSS users until TestInfo V2 lands. `root` is a common name for root cells, it is generic and it is the default when running `buck2 init`, making it a bad name that is not descriptive and likely to conflict with downstream cells. As described in the added docs, this commit is not an ideal solution, since it requires configuration hacks: - The root `.buckconfig` must point to Buck2's shim directory. - Buck2's `.buckconfig` must be edited to remove cells that are already defined in the root.
|
@JakobDegen Is something blocking this PR? |
|
I recently went through and standardized our cell naming internally - slightly verbose, but unique / predictable now. Anyone mind if I close this PR? |
|
No problem, thanks for doing this! |
This commit renames the
rootcell to facilitate embedding it as a dependency to Rust projects. While the Buck2 repository does not have an official public API, depending on it is the most reasonable way of writing custom test runners, which is important for OSS users until TestInfo V2 lands.rootis a common name for root cells, it is generic and it is the default when runningbuck2 init, making it a bad name that is not descriptive and likely to conflict with downstream cells.As described in the added docs, this commit is not an ideal solution, since it requires configuration hacks:
.buckconfigmust point to Buck2's shim directory..buckconfigmust be edited to remove cells that are already defined in the root.Relates to #684.