feat: fix apple toolchain apple framework #740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
pollend
force-pushed
the
feature/fix-apple-toolchain-apple-framework
branch
from
254c5ca to
8bc770a
Compare
pollend
commented
Aug 17, 2024
|
|
||
| def _system_apple_toolschain_impl(ctx: AnalysisContext) -> list[Provider]: | ||
| xcode_bin_path = "{}/Contents/Developer/usr/bin".format(ctx.attrs.xcode_app) | ||
| sdk_path = "{}/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk".format(ctx.attrs.xcode_app) |
There was a problem hiding this comment.
I'm a little confused on how to handle this.
there is
buck2 % xcrun --sdk macosx --show-sdk-path
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14
.5.sdk
pollend
commented
Aug 17, 2024
Comment on lines
24
to
+28
| def get_apple_toolchain_attr(): | ||
| # FIXME: prelude// should be standalone (not refer to fbcode//) | ||
| return attrs.toolchain_dep(default = "fbcode//buck2/platform/toolchain:apple-default", providers = [AppleToolchainInfo]) | ||
| return attrs.toolchain_dep(default = "toolchains//:apple", providers = [AppleToolchainInfo]) | ||
|
|
||
| def get_apple_bundle_toolchain_attr(): | ||
| # FIXME: prelude// should be standalone (not refer to fbcode//) | ||
| return attrs.toolchain_dep(default = "fbcode//buck2/platform/toolchain:apple-bundle", providers = [AppleToolchainInfo]) | ||
| return attrs.toolchain_dep(default = "toolchains//:apple", providers = [AppleToolchainInfo]) |
There was a problem hiding this comment.
is there a situation for multiple toolchains to be needed?
|
I added a small example to hello world to demonstrate this working. how does cxx_library and cxx_binary fit into this because those break if they don't have an sdk version available |
Signed-off-by: Michael Pollind <[email protected]>
Signed-off-by: Michael Pollind <[email protected]>
Signed-off-by: Michael Pollind <[email protected]>
Signed-off-by: Michael Pollind <[email protected]>
pollend
force-pushed
the
feature/fix-apple-toolchain-apple-framework
branch
from
3a4d150 to
c9d58c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just been roughly trying to get this to work for my local setup. some of this is a bit hacked away to get this to work but I think its in the general right direction.
this is what I have in mind for resolving the apple tools
here is the working code I'm trying to test
here is my sample application that I've been testing these changes with: https://github.com/OSS-Cosmic/buck2-samples/tree/main/hello_world
I need to build this locally and verify it on my own system but this is what I have so far.