Skip to content
  • Sponsor facebook/create-react-app

  • Notifications You must be signed in to change notification settings
  • Fork 27k
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc server example to work from any directory #1988

Merged
merged 2 commits into from
Apr 19, 2017
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Node.js serving with absolute path
It’s safer to use the absolute path of the directory that you want to serve, in case you run the express app from another directory.
isramos authored Apr 17, 2017
commit ebdb646b4c769e8bdfe8ba76167bc2010918b282
2 changes: 1 addition & 1 deletion packages/react-scripts/template/README.md
Original file line number Diff line number Diff line change
@@ -1242,7 +1242,7 @@ const express = require('express');
const path = require('path');
const app = express();

app.use(express.static('./build'));
app.use(express.static(path.join(__dirname, 'build')))

app.get('/', function (req, res) {
res.sendFile(path.join(__dirname, './build', 'index.html'));
Copy link
Contributor

@Timer Timer Apr 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this code was already here, but is the ./ for ./build required, or worse, mess anything up?