Skip to content
/ create-react-app Public

  • Sponsor facebook/create-react-app

    External links
    open_collective
    opencollective.com/create-react-app

    Learn more about funding links in repositories.

    Report abuse

  • Notifications You must be signed in to change notification settings
  • Fork 27k
  • Star 103k
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prioritize index.css over the implicit App.css #2470

Merged
merged 1 commit into from
Jun 5, 2017
Merged

Prioritize index.css over the implicit App.css #2470

merged 1 commit into from
Jun 5, 2017
+1 −1

Conversation

bananatranada
Copy link

Hi. I'm under the assumption that index.css is used for global styles not associated with any component. This is where I import 3rd party css libraries as well. However, I noticed that it would override the styles in App.css.

@bryankang
Prioritize index.css over the implicit App.css

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
86da58d
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon gaearon added this to the 1.0.8 milestone Jun 5, 2017
@gaearon
Copy link
Contributor

gaearon commented Jun 5, 2017

That’s a good catch.

@gaearon gaearon merged commit b264b8d into facebook:master Jun 5, 2017
@piotr-cz piotr-cz mentioned this pull request Jun 8, 2017
Closed
paweljedrzejczyk pushed a commit to paweljedrzejczyk/create-react-app that referenced this pull request Jun 12, 2017
@backstroke-bot @paweljedrzejczyk
Update from upstream repo facebookincubator/create-react-app (#1)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
16c642e 
* Update Travis CI Node versions in User Guide (facebook#2454)

Removed Node v4 (CRA only supports Node >= 6)

* re-add storybook && update the documentation and links (facebook#2331)

* re-add storybook && update the documentation and links

* Change to new documentation domain

* Prioritize index.css over the implicit App.css (facebook#2470)

* Added NamedModulesPlugin in webpack.config.dev.js (facebook#2458)

* Added NamedModulesPlugin in webpack.config.dev.js

* Update webpack.config.dev.js

* Unscope detect-port (facebook#2483)

Resolves facebook#2481

* Update webpack links to point to webpack 2 (facebook#2492)

* Update README.md to make links to webpack point to webpack.js.org instead
  insteade of webpack 1 webpack.githup.io

* chore(templates): Move GitHub templates to hidden .github folder (facebook#2489)

* Fix minor docs typo (facebook#2500)

* Fix link to Storybook docs (facebook#2521)

* Simplify flow init docs (facebook#2522)

- Call `npm run flow --init` won't create a .flowconfig file, it should be `npm run flow init`
@gaearon gaearon mentioned this pull request Jun 28, 2017
Merged
@gaearon
Copy link
Contributor

gaearon commented Jun 28, 2017

Fixed in latest version. Please verify.
https://github.com/facebookincubator/create-react-app/releases/tag/v1.0.8

romaindso pushed a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017
@bryankang @romaindso
Prioritize index.css over the implicit App.css (facebook#2470)
486d097
wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017
@bryankang @wmonk
Prioritize index.css over the implicit App.css (#2470)
ad5b884
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
1.0.8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bananatranada @facebook-github-bot @gaearon @bryankang