Adds recipe for adding React Router (v4) to README template #887
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| @@ -409,6 +410,18 @@ import { Navbar, Jumbotron, Button } from 'react-bootstrap'; | |||
|
|
|||
| Now you are ready to use the imported React Bootstrap components within your component hierarchy defined in the render method. Here is an example [`App.js`](https://gist.githubusercontent.com/gaearon/85d8c067f6af1e56277c82d19fd4da7b/raw/6158dd991b67284e9fc8d70b9d973efe87659d72/App.js) redone using React Bootstrap. | |||
|
|
|||
| ## Adding React Router | |||
|
|
|||
| React Router is a popular solution for adding routing capabilities to your single-page applications. If your app needs routing, you can configure React Router to work with Create React app by following these steps: | |||
There was a problem hiding this comment.
I think the word 'app' should start with a capital letter when 'Create React App' is mentioned
|
I would just add that in order for all links to work, you have to provide the basename attribute for the <BrowserRouter basename={process.env.PUBLIC_URL}>
...
</BrowserRouter> |
|
Probably going to wait on this until RR4 hits stable. |
Addresses issue #641 by adding React Router recipe to the README files as appropriate.