Back out "Update directly connected routes if any updates"

Summary:
Original commit changeset: 8d2fc26d5172

Original Phabricator Diff: D54049829

Reviewed By: zechengh09

Differential Revision: D56641955

fbshipit-source-id: a27d46d517fe12c4aba978870c223a0e2ca16444

fboss/agent/DsfStateUpdaterUtil.cpp

@@ -73,12 +73,11 @@ namespace facebook::fboss {
 std::shared_ptr<SwitchState> DsfStateUpdaterUtil::getUpdatedState(
     const std::shared_ptr<SwitchState>& in,
     const SwitchIdScopeResolver* scopeResolver,
-    RoutingInformationBase* rib,
+    RoutingInformationBase* /* rib */,
     const std::map<SwitchID, std::shared_ptr<SystemPortMap>>&
         switchId2SystemPorts,
     const std::map<SwitchID, std::shared_ptr<InterfaceMap>>& switchId2Intfs) {
   bool changed{false};
-  bool intfChanged{false};
   auto out = in->clone();
 
   auto skipProgramming = [&](const auto& nbrEntryIter) -> bool {
@@ -264,11 +263,6 @@ std::shared_ptr<SwitchState> DsfStateUpdaterUtil::getUpdatedState(
     InterfaceMapDelta delta(origRifs.get(), newRifs.get());
     auto remoteRifs = out->getRemoteInterfaces()->modify(&out);
     processDelta(delta, remoteRifs, makeRemoteRif);
-    intfChanged |= (delta.begin() != delta.end());
-  }
-
-  if (intfChanged) {
-    updateRemoteConnectedRoutes(out, scopeResolver, rib);
   }
 
   if (changed) {