Skip to content

Commit

Permalink
Create unique id for new subscriptions
Browse files Browse the repository at this point in the history
Summary:
In ServiceHandler, while registering new subscriptions use a unique id.
In next diff we will use this unique ID to pull information from Subscription
objects in SubscriptionManager into Fsdb Service handler.

Reviewed By: wilsonwinhi

Differential Revision: D67867191

fbshipit-source-id: b8fea88859e6576f9d3de343a5fdc63ad308997e
  • Loading branch information
Priyank Warkhede authored and facebook-github-bot committed Feb 25, 2025
1 parent f788540 commit 9eb8197
Show file tree
Hide file tree
Showing 4 changed files with 117 additions and 55 deletions.
1 change: 1 addition & 0 deletions fboss/fsdb/if/fsdb.thrift
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ struct OperSubscriberInfo {
// Paths for Patch apis
// TODO: replace path above
7: optional map<fsdb_oper.SubscriptionKey, fsdb_oper.RawOperPath> paths;
8: optional i64 subscriptionUid;
}

@cpp.Type{template = "folly::F14FastMap"}
Expand Down
1 change: 1 addition & 0 deletions fboss/fsdb/server/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ cpp_library(
"//fboss/fsdb/if:fsdb_model",
"//fboss/fsdb/if:fsdb_oper-cpp2-types",
"//fboss/fsdb/oper:path_helpers",
"//fboss/fsdb/oper:subscription_common",
"//fboss/fsdb/oper/instantiations:fsdb_naive_periodic_subscribable_storage",
"//fboss/lib:log_thrift_call",
"//fboss/lib:thread_heartbeat",
Expand Down
Loading

0 comments on commit 9eb8197

Please sign in to comment.