Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

janga: config: added patch files for rack fan service #337

Closed
wants to merge 2 commits into from

Conversation

zhongedward
Copy link
Contributor

@zhongedward zhongedward commented Feb 18, 2025

Description
This PR is for janga & tahan rack fan service path files.

Motivation
1.Based on quanta's input fan configuration file, I created a fan_service patch file and a platform_manager patch file based on the current files in the fboss repo.
2.In the patch files, I mainly added the gpio symbolic link.

image

image

3.Note:
The fan_service patch file is a transitional version, quanta will change some parameters in the future, I will keep a close eye on it.

Test Plan
1.Tested both in janga & tahan rack machines.

image

2.Test log as follows:

tahan_rack_test_log_2_17.txt
janga_rack_test_log_2_17.txt

@kimdo8736
Copy link

I was expecting fan_service.json and platform_manager.json from our discussion in workplace.

The PR contains .patch files which has content diffs. Can you please update with new json files?

@zhongedward
Copy link
Contributor Author

@kimdo8736 Hi kim, I have updated the new json files, please review, thanks

@kimdo8736
Copy link

@zhongedward,

I see two changes in this PR:

  1. PWMs values changes per temperatures / sensor name change
  2. GPIO presence introduction.

Can you separate the PRs? I can import #1 changes to internal Meta. We may need to wait #2 as the Janga/Tahan PVT units in our lab is still in test fixture.

@zhongedward
Copy link
Contributor Author

@kimdo8736 Hi kim, yes, fan_service.json is provided by quanta and it is only used for rack macine, while platform_manager.json is Matching, and their 2 files should be used together on the rack machine, not separately.
Sorry, I'm a bit confused by your suggestion, are you saying I need to separate the GPIO part (both in fan_service.json and platform_manager.json)? If so, can it be used in the test fixture? Could you please give me some more clear instructions? thanks!

@zhongedward
Copy link
Contributor Author

I'm thinking again that it either doesn't import, or if it does, it needs to be imported together and then applied to the rack machine. Because the test fixure's fan config file and the rack's fan config file are separate. Please correct me if I'm wrong, thanks!

@zhongedward
Copy link
Contributor Author

Based on the replies in the workspace, I've turned off PR for now. i'll turn it back on when Quanta is done.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants