fboss : tahan : added HwPimTest.CheckPimPresent to the unsupported QSFP tests list. #340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the recent commit
HwPimTest.CheckPimPresent
test fails for Tahan.The old implementation had the following statement which always compared a value to itself. It wouldn't have caught any issues with the number of slots or PIMs.
EXPECT_EQ(phyManager->getNumOfSlot(), phyManager->getNumOfSlot());
// This is always true!The new implementation now correctly checks if the number of slots reported by the
phyManager
matches the number of PIMs reported by thegetSystemContainer
. The failure indicates these numbers are different.Following the aforementioned commit that introduced the failing test, Meta added
HwPimTest.CheckPimPresent
to the unsupported test list for MP3 in the commitPlease note, this test is already on the unsupported list for Janga and now failing only on Tahan.
PR is raised to add it to the unsupported list for Tahan as well, similar to MP3 and Janga.
Testing