adress comments

facebook · May 29, 2024 · d438edd · d438edd
1 parent 0b52e13
commit d438edd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/packages/lexical-list/src/LexicalListItemNode.ts b/packages/lexical-list/src/LexicalListItemNode.ts
@@ -24,7 +24,6 @@ import type {
 
 import {
   addClassNamesToElement,
-  isHTMLElement,
   removeClassNamesFromElement,
 } from '@lexical/utils';
 import {
@@ -493,14 +492,14 @@ function updateListItemChecked(
   }
 }
 
-function $convertListItemElement(domNode: Node): DOMConversionOutput {
+function $convertListItemElement(domNode: HTMLElement): DOMConversionOutput {
+  const ariaCheckedAttr = domNode.getAttribute('aria-checked');
   const checked =
-    isHTMLElement(domNode) &&
-    (domNode.getAttribute('aria-checked') === 'true'
+    ariaCheckedAttr === 'true'
       ? true
-      : domNode.getAttribute('aria-checked') === 'false'
+      : ariaCheckedAttr === 'false'
       ? false
-      : undefined);
+      : undefined;
   return {node: $createListItemNode(checked)};
 }
 

diff --git a/packages/lexical-playground/src/nodes/ImageNode.tsx b/packages/lexical-playground/src/nodes/ImageNode.tsx
@@ -42,7 +42,7 @@ function isGoogleDocCheckboxImg(img: HTMLImageElement): boolean {
     img.parentElement != null &&
     img.parentElement.tagName === 'LI' &&
     img.previousSibling === null &&
-    img.src.startsWith('data:image/png;base64,iVBOR')
+    img.getAttribute('aria-roledescription') === 'checkbox'
   );
 }