Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Chore: Switch to new SSH key #7131

Closed
wants to merge 2 commits into from
Closed

[ci] Chore: Switch to new SSH key #7131

wants to merge 2 commits into from

Conversation

acywatson
Copy link
Contributor

Description

Rotates to a new SSH Key in Github Actions

Test plan

Evaluate nightly release run. Or do a dry run, if possible?

Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 8:50pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 8:50pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 4, 2025
zurfyx
zurfyx previously approved these changes Feb 4, 2025
etrepum
etrepum previously approved these changes Feb 4, 2025
@etrepum
Copy link
Collaborator

etrepum commented Feb 4, 2025

Should be able to test this by running the Create New Release Branch workflow, which only depends on this SSH_KEY_2 secret and not the NPM_TOKEN secret

@etrepum
Copy link
Collaborator

etrepum commented Feb 4, 2025

Looks like it fails actually, see https://github.com/facebook/lexical/actions/runs/13142675139

You can run the workflow with this branch as a target

@etrepum etrepum dismissed their stale review February 4, 2025 19:04

Doesn't work after testing

ivailop7
ivailop7 previously approved these changes Feb 4, 2025
@potatowagon
Copy link
Contributor

do we still need this?

@zurfyx zurfyx closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants