Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical] Chore: Added missing isInline function to TextNode #7226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

[lexical] Chore: Added missing isInline function to TextNode #7226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/lexical/src/nodes/LexicalTextNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,13 @@ export class TextNode extends LexicalNode {
return true;
}

/**
* @returns true if the text node is inline, false otherwise.
*/
isInline(): boolean {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this does make sense to implement on TextNode, it would make sense to also narrow the implementation to return only true, because it's not permitted for any subclass to return false

Suggested change
isInline(): boolean {
isInline(): true {

return true;
}

// View

createDOM(config: EditorConfig, editor?: LexicalEditor): HTMLElement {
Expand Down