Cleanup comms pre-landing

facebook · Feb 12, 2025 · eec3264 · eec3264
1 parent b8471d2
commit eec3264
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/db/arena_wrapped_db_iter.cc b/db/arena_wrapped_db_iter.cc
@@ -114,7 +114,7 @@ void ArenaWrappedDBIter::MaybeAutoRefresh(bool is_seek,
       //                            ---- T3: Seek(T)
       //
       bool valid = false;
-      std::string key = "";
+      std::string key;
       if (!is_seek && db_iter_->Valid()) {
         // The key() Slice is valid until the iterator state changes.
         // Given that refresh is heavy-weight operation it itself,

diff --git a/include/rocksdb/options.h b/include/rocksdb/options.h
@@ -1956,9 +1956,14 @@ struct ReadOptions {
   // negligible. We expect the default value to be true some time in the future.
   //
   // NOTE 1: Does not have effect on TransactionDB with WRITE_PREPARED or
-  //         WRITE_UNPREPARED policies.
-  //
-  // NOTE 2: Not recommended if your application is reading UDT timestamps.
+  //         WRITE_UNPREPARED policies (currently incompatible).
+  //
+  // NOTE 2: True is not recommended if using user-defined timestamp with
+  //         persist_user_defined_timestamps=false and non-nullptr
+  //         ReadOptions::timestamp or ReadOptions::iter_start_ts, because
+  //         auto-refreshing iterator will not prevent user timestamp
+  //         information from being dropped during iteration. Auto-refresh might
+  //         be disabled for this combination in the future.
   //
   // Default: false
   bool auto_refresh_iterator_with_snapshot = false;