Fix build on OpenBSD i386 #12142
Closed
Fix build on OpenBSD i386 #12142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhubner
force-pushed
the
eb/openbsd-fix
branch
2 times, most recently
from
1be9a7b to
8689b80
Compare
rhubner
force-pushed
the
eb/openbsd-fix
branch
from
8689b80 to
ce3ecb0
Compare
adamretter
reviewed
Jan 23, 2024
| @@ -28,6 +31,12 @@ public MultiGetManyKeysTest(final Integer numKeys) { | |||
| this.numKeys = numKeys; | |||
| } | |||
|
|
|||
| @BeforeClass | |||
| public static void beforeAllTest() { | |||
| Assume.assumeFalse("We are not running this test on OpenBSD dues to memory constraints", | |||
There was a problem hiding this comment.
Is this a problem on both OpenBSD 32 bit and 64 bit? If this is about memory limits, perhaps instead use !Environment.is64Bit()?
There was a problem hiding this comment.
Can you also fix the message please, as it is now 32bit specific and not OpenBSD specific @rhubner please?
adamretter
reviewed
Jan 23, 2024
adamretter
reviewed
Jan 23, 2024
rhubner
force-pushed
the
eb/openbsd-fix
branch
from
ce3ecb0 to
0db3e46
Compare
rhubner
force-pushed
the
eb/openbsd-fix
branch
from
0db3e46 to
3adfb8b
Compare
ajkr
approved these changes
Jan 27, 2024
|
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.