Skip to content
This repository was archived by the owner on Mar 20, 2026. It is now read-only.

[WIP] Refactor sequence generator#4723

Open
hirofumi0810 wants to merge 1 commit intomainfrom
refactor_seq_gen
Open

[WIP] Refactor sequence generator#4723
hirofumi0810 wants to merge 1 commit intomainfrom
refactor_seq_gen

Conversation

@hirofumi0810
Copy link
Copy Markdown

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Refactored sequence generator to reuse the function generate_decoder for multi-decoder models. The multi-decoder models will be added after this PR.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Copy Markdown
Contributor

@sravyapopuri388 sravyapopuri388 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem correct to me but seems like some tests are breaking. Can we update the changes so the tests pass and also verify on some existing models to ensure that the changes are backward compatible

https://github.com/facebookresearch/fairseq/actions/runs/3058436996/jobs/4934645467

@hirofumi0810 hirofumi0810 mentioned this pull request Sep 16, 2022
4 tasks
@hirofumi0810 hirofumi0810 changed the title Refactor sequence generator [WIP] Refactor sequence generator Sep 20, 2022
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Oct 22, 2025

Hi @hirofumi0810!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants