[WIP] Refactor sequence generator#4723
Conversation
There was a problem hiding this comment.
The changes seem correct to me but seems like some tests are breaking. Can we update the changes so the tests pass and also verify on some existing models to ensure that the changes are backward compatible
https://github.com/facebookresearch/fairseq/actions/runs/3058436996/jobs/4934645467
|
Hi @hirofumi0810! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Before submitting
What does this PR do?
Refactored sequence generator to reuse the function
generate_decoderfor multi-decoder models. The multi-decoder models will be added after this PR.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃