Skip to content
This repository was archived by the owner on Mar 20, 2026. It is now read-only.

Fix Must-C data preprocessing#4767

Open
hirofumi0810 wants to merge 3 commits intomainfrom
fix_mustc
Open

Fix Must-C data preprocessing#4767
hirofumi0810 wants to merge 3 commits intomainfrom
fix_mustc

Conversation

@hirofumi0810
Copy link
Copy Markdown

@hirofumi0810 hirofumi0810 commented Oct 7, 2022

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

  • Fixed calculation of input statistics. The default --gcmvn-max-num was too small. It didn't use the whole training samples to calculate the statistics.
  • Supported waveform inputs + global cmvn.
  • Fixed data filtering for dev and test sets. Previously, both dev and test sets were also filtered based on the input lengths (max=3000, min=5).
  • Added a src_text column to manifests, which would be helpful for joint ASR+ST training.
  • Support waveform segmentation, which is used for SimulEval, for streaming ASR

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Oct 22, 2025

Hi @hirofumi0810!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants