Skip to content
This repository was archived by the owner on Mar 20, 2026. It is now read-only.

Patch 1#4828

Open
iakovosevdaimon wants to merge 8 commits intofacebookresearch:mainfrom
iakovosevdaimon:patch-1
Open

Patch 1#4828
iakovosevdaimon wants to merge 8 commits intofacebookresearch:mainfrom
iakovosevdaimon:patch-1

Conversation

@iakovosevdaimon
Copy link
Copy Markdown

@iakovosevdaimon iakovosevdaimon commented Oct 25, 2022

  1. Update of hub_interface.py: Add add_if_not_exist parameter in the encode function of hub_interface.py of BART model, because otherwise there are mismatch issues.

  2. Update denoising task: Fix mistakes in the default values, type, and explanation of the parameters permute_sentences, shuffle_instance, and replace_length

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # Solve the mismatch issues of encoder embeddings during inference. Also update the parameters of the denoising task, because otherwise, the sentence permutation perturbation scheme doesn't work correctly by using the default value. Moreover, fix the misleading default values and descriptions of some parameters.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

 Add add_if_not_exist parameter in the encode function of hub_interface.py of BART model, because otherwise there are mismatch issues
Fix mistakes in the default values, type, and explanation of the parameters permute_sentences, shuffle_instance, and replace_length
@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @iakovos777!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants