Patch 1#4828
Conversation
Add add_if_not_exist parameter in the encode function of hub_interface.py of BART model, because otherwise there are mismatch issues
Fix mistakes in the default values, type, and explanation of the parameters permute_sentences, shuffle_instance, and replace_length
|
Hi @iakovos777! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Update of hub_interface.py: Add add_if_not_exist parameter in the encode function of hub_interface.py of BART model, because otherwise there are mismatch issues.
Update denoising task: Fix mistakes in the default values, type, and explanation of the parameters permute_sentences, shuffle_instance, and replace_length
Before submitting
What does this PR do?
Fixes # Solve the mismatch issues of encoder embeddings during inference. Also update the parameters of the denoising task, because otherwise, the sentence permutation perturbation scheme doesn't work correctly by using the default value. Moreover, fix the misleading default values and descriptions of some parameters.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃