warn missing x_scatter in read simulated spectrum instead of exception#127
Open
jebuss wants to merge 1 commit into
Open
warn missing x_scatter in read simulated spectrum instead of exception#127jebuss wants to merge 1 commit into
jebuss wants to merge 1 commit into
Conversation
…an exception. This is needed for old MMCs corsikas who do not have this attribute
maxnoe
reviewed
Jun 14, 2019
Member
maxnoe
left a comment
maxnoe
left a comment
There was a problem hiding this comment.
No, the idea was that the new files contain a column with the info and for the old files we just add the attribute.
As this information is needed, I think raising an error is better when it's not there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
warn missing x_scatter in read simulated spectrum instead of raising an exception. This is needed for old MMCs corsikas who do not have this attribute