Skip to content

Commit

Permalink
fix CapabilityFactory test with DI
Browse files Browse the repository at this point in the history
  • Loading branch information
gtrias committed Sep 6, 2024
1 parent 6ac6d8d commit c00faf7
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
11 changes: 8 additions & 3 deletions lib/public/capability_factory.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,15 @@ module ResourceRegistry
class CapabilityFactory
extend T::Sig

sig { params(data: T::Hash[String, T.untyped]).returns(Capabilities::CapabilityConfig) }
def self.load(data)
sig do
params(
data: T::Hash[String, T.untyped],
capabilities: T::Hash[Symbol, T.all(T::Class[Capabilities::CapabilityConfig], T.class_of(T::Struct))]
).returns(Capabilities::CapabilityConfig)
end
def self.load(data, capabilities: ResourceRegistry.configuration.capabilities)
key = data['key']
capability = ResourceRegistry.configuration.capabilities.fetch(key.to_sym)
capability = capabilities.fetch(key.to_sym)
# FIXME: This T.let should not be needed
T.let(capability, T.class_of(T::Struct)).from_hash(data)
end
Expand Down
2 changes: 1 addition & 1 deletion spec/capability_factory_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
let(:data) { { 'key' => 'dummy_capability', :time_dimension => 'bar' } }

it do
cap = capability.load(data)
cap = capability.load(data, capabilities: { dummy_capability: DummyCapability })
expect(described_class.dump(cap)).to include_json(time_dimension: 'bar')
end
end
Expand Down

0 comments on commit c00faf7

Please sign in to comment.